| Date | Thu, 8 Aug 2019 12:24:52 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH v3 hmm 01/11] mm/mmu_notifiers: hoist do_mmu_notifier_register down_write to the caller |
| |
On Tue, Aug 06, 2019 at 08:15:38PM -0300, Jason Gunthorpe wrote: > From: Jason Gunthorpe <jgg@mellanox.com> > > This simplifies the code to not have so many one line functions and extra > logic. __mmu_notifier_register() simply becomes the entry point to > register the notifier, and the other one calls it under lock. > > Also add a lockdep_assert to check that the callers are holding the lock > as expected. > > Suggested-by: Christoph Hellwig <hch@infradead.org> > Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
|