Messages in this thread | | | From | Felipe Balbi <> | Subject | Re: [PATCH v2 2/2 RESEND] usb: dwc3: remove generic PHY calibrate() calls | Date | Thu, 08 Aug 2019 12:51:20 +0300 |
| |
Hi,
Marek Szyprowski <m.szyprowski@samsung.com> writes:
> Calls to USB2 generic PHY calibrate() method has been moved to HCD core, > which now successfully handles generic PHYs and their calibration after > every HCD reset. This fixes all the timing issues related to PHY > calibration done directly from DWC3 driver: incorrect operation after > system suspend/resume or USB3.0 detection failure when XHCI-plat driver > compiled as separate module. > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > Tested-by: Anand Moon <linux.amoon@gmail.com> > Tested-by: Jochen Sprickerhof <jochen@sprickerhof.de> > --- > drivers/usb/dwc3/core.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > index c9bb93a2c81e..7dd6d419254d 100644 > --- a/drivers/usb/dwc3/core.c > +++ b/drivers/usb/dwc3/core.c > @@ -168,7 +168,6 @@ static void __dwc3_set_mode(struct work_struct *work) > otg_set_vbus(dwc->usb2_phy->otg, true); > phy_set_mode(dwc->usb2_generic_phy, PHY_MODE_USB_HOST); > phy_set_mode(dwc->usb3_generic_phy, PHY_MODE_USB_HOST); > - phy_calibrate(dwc->usb2_generic_phy);
are you sure you're the only one using phy_calibrate()? I don't want any regressions because of this :-p
-- balbi [unhandled content-type:application/pgp-signature]
| |