Messages in this thread | | | Date | Wed, 7 Aug 2019 16:42:20 +0100 | From | Quentin Perret <> | Subject | Re: [PATCH v6 3/3] thermal: cpu_cooling: Migrate to using the EM framework |
| |
Hi all,
On Thursday 01 Aug 2019 at 13:46:43 (+0100), Quentin Perret wrote: > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > index 9966364a6deb..340853a3ca48 100644 > --- a/drivers/thermal/Kconfig > +++ b/drivers/thermal/Kconfig > @@ -144,6 +144,7 @@ config THERMAL_GOV_USER_SPACE > > config THERMAL_GOV_POWER_ALLOCATOR > bool "Power allocator thermal governor" > + depends on ENERGY_MODEL > help > Enable this to manage platform thermals by dynamically > allocating and limiting power to devices.
FYI, the kbuild bot just reported a randconfig build issue with this. THERMAL_DEFAULT_GOV_POWER_ALLOCATOR 'select' THERMAL_GOV_POWER_ALLOCATOR unconditionally. And I just learned 'select' will force the option ON and totally ignore its dependencies. That is, we can end up with IPA force-compiled in, and no PM_EM, which is broken.
So I guess the simplest fix is to do 'select ENERGY_MODEL' in this patch, instead of depending on it.
I'll send a v7 with this fixed shortly.
Thanks, Quentin
| |