lkml.org 
[lkml]   [2019]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] riscv: move sifive_l2_cache.c to drivers/misc
On Wed, 7 Aug 2019, Christoph Hellwig wrote:

> On Wed, Aug 07, 2019 at 05:22:15PM +0200, Greg KH wrote:
> > > Fixes: a967a289f169 ("RISC-V: sifive_l2_cache: Add L2 cache controller driver for SiFive SoCs")
> > > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > > ---
> > > arch/riscv/mm/Makefile | 1 -
> > > drivers/misc/Makefile | 1 +
> > > {arch/riscv/mm => drivers/misc}/sifive_l2_cache.c | 0
> > > 3 files changed, 1 insertion(+), 1 deletion(-)
> > > rename {arch/riscv/mm => drivers/misc}/sifive_l2_cache.c (100%)
> >
> > Why isn't this in drivers/edac/ ?
> > why is this a misc driver? Seems like it should sit next to the edac
> > stuff.
>
> No idea. EDAC maintainers, would you object to taking what is
> currently in arch/riscv/mm//sifive_l2_cache.c to drivers/edac/ ?

If this driver is moved out of arch/riscv/mm, it should ideally go into
some sort of common L2 cache controller driver directory, along
with other L2 cache controller drivers like arch/arm/mm/*l2c*.

Like many L2 cache controllers, this controller also supports cache
flushing operations and SoC-specific way operations. We just don't use
those on RISC-V - yet.


- Paul

\
 
 \ /
  Last update: 2019-08-07 17:42    [W:1.510 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site