Messages in this thread | | | Date | Wed, 7 Aug 2019 14:02:05 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH v2 1/2] binder: Add default binder devices through binderfs when configured |
| |
On Tue, Aug 06, 2019 at 11:40:05AM -0700, Hridya Valsaraju wrote: > @@ -467,6 +466,9 @@ static int binderfs_fill_super(struct super_block *sb, void *data, int silent) > int ret; > struct binderfs_info *info; > struct inode *inode = NULL; > + struct binderfs_device device_info = { 0 }; > + const char *name; > + size_t len; > > sb->s_blocksize = PAGE_SIZE; > sb->s_blocksize_bits = PAGE_SHIFT; > @@ -521,7 +523,24 @@ static int binderfs_fill_super(struct super_block *sb, void *data, int silent) > if (!sb->s_root) > return -ENOMEM; > > - return binderfs_binder_ctl_create(sb); > + ret = binderfs_binder_ctl_create(sb); > + if (ret) > + return ret; > + > + name = binder_devices_param; > + for (len = strcspn(name, ","); len > 0; len = strcspn(name, ",")) { > + strscpy(device_info.name, name, len + 1); > + ret = binderfs_binder_device_create(inode, NULL, &device_info); > + if (ret) > + return ret;
We should probably clean up before returning... The error handling code would probably be tricky to write though and it's not super common.
> + name += len; > + if (*name == ',') > + name++; > + > + } > + > + return 0; > +
Remove this extra blank line.
> }
regards, dan carpenter
| |