Messages in this thread | | | Date | Tue, 6 Aug 2019 16:54:07 +0100 | From | Sudeep Holla <> | Subject | Re: [PATCH 3/6] drivers: firmware: psci: Decouple checker from generic ARM CPUidle |
| |
On Mon, Jul 22, 2019 at 04:37:42PM +0100, Lorenzo Pieralisi wrote: > The PSCI checker currently relies on the generic ARM CPUidle > infrastructure to enter an idle state, which in turn creates > a dependency that is not really needed. > > The PSCI checker code to test PSCI CPU suspend is built on > top of the CPUidle framework and can easily reuse the > struct cpuidle_state.enter() function (previously initialized > by an idle driver, with a PSCI back-end) to trigger an entry > into an idle state, decoupling the PSCI checker from the > generic ARM CPUidle infrastructure and simplyfing the code > in the process. > > Convert the PSCI checker suspend entry function to use > the struct cpuidle_state.enter() function callback. > > Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > Cc: Sudeep Holla <sudeep.holla@arm.com>
Not sure why we didn't take this path from the beginning. Anyways make sense and much needed for later patches in the series.
Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
-- Regards, Sudeep
| |