lkml.org 
[lkml]   [2019]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] gpiolib: Take MUX usage into account
On Tue, Aug 6, 2019 at 3:04 PM Linus Walleij <linus.walleij@linaro.org> wrote:
> On Sat, Aug 3, 2019 at 3:34 PM Ramon Fried <rfried.dev@gmail.com> wrote:
>
> > From: Stefan Wahren <stefan.wahren@i2se.com>
> >
> > The user space like gpioinfo only see the GPIO usage but not the
> > MUX usage (e.g. I2C or SPI usage) of a pin. As a user we want to know which
> > pin is free/safe to use. So take the MUX usage of strict pinmux controllers
> > into account to get a more realistic view for ioctl GPIO_GET_LINEINFO_IOCTL.
> >
> > Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> > Tested-By: Ramon Fried <rfried.dev@gmail.com>
> > Signed-off-by: Ramon Fried <rfried.dev@gmail.com>
> > ---
> > Sending Stefan's RFC as patch, as I tested it and it seems to work,
> > additionally, an accompanying fix was made by me to gpiolibd to fix a
> > display error of the actual result:
> > https://patchwork.ozlabs.org/patch/1139923/
>
> This is mostly fine, some style nits so I fixed it up when
> applying.

Ooops no. It needs a deeper rework in accordance to my comments
last time it was posted. Please read this reply to Stefan's patch
and address the comments:

https://lore.kernel.org/linux-gpio/CACRpkdb5DjAMRYkT+b0U6HVk7E6ccLT79-LB=QGQWWtE17aPUg@mail.gmail.com/

Yours,
Linus Walleij

\
 
 \ /
  Last update: 2019-08-06 15:13    [W:0.069 / U:0.744 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site