Messages in this thread | | | Date | Tue, 6 Aug 2019 15:04:27 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] Staging: rtl8188eu: core: rtw_security: fixed a coding style issue |
| |
On Tue, Aug 06, 2019 at 05:24:38PM +0530, Merwin Trever Ferrao wrote: > Fixed WARNING: else is not generally useful after a break or return > ---
Much better, but you forgot the the Signed-off-by so we can't apply it.
Also it's nice to be more specific with the subject. [PATCH] Staging: rtl8188eu: rtw_security: tidy up crc32_init(). And for the full commit message maybe write something like:
This code generates a checkpatch warning:
WARNING: else is not generally useful after a break or return
If we move the declarations to the start of the function then we can pull the code back one tab and it makes the function a lot more readable.
regards, dan carpenter
| |