lkml.org 
[lkml]   [2019]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 20/74] ACPI: blacklist: fix clang warning for unused DMI table
    Date
    [ Upstream commit b80d6a42bdc97bdb6139107d6034222e9843c6e2 ]

    When CONFIG_DMI is disabled, we only have a tentative declaration,
    which causes a warning from clang:

    drivers/acpi/blacklist.c:20:35: error: tentative array definition assumed to have one element [-Werror]
    static const struct dmi_system_id acpi_rev_dmi_table[] __initconst;

    As the variable is not actually used here, hide it entirely
    in an #ifdef to shut up the warning.

    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
    Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/acpi/blacklist.c | 4 ++++
    1 file changed, 4 insertions(+)

    diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c
    index 995c4d8922b12..761f0c19a4512 100644
    --- a/drivers/acpi/blacklist.c
    +++ b/drivers/acpi/blacklist.c
    @@ -30,7 +30,9 @@

    #include "internal.h"

    +#ifdef CONFIG_DMI
    static const struct dmi_system_id acpi_rev_dmi_table[] __initconst;
    +#endif

    /*
    * POLICY: If *anything* doesn't work, put it on the blacklist.
    @@ -74,7 +76,9 @@ int __init acpi_blacklisted(void)
    }

    (void)early_acpi_osi_init();
    +#ifdef CONFIG_DMI
    dmi_check_system(acpi_rev_dmi_table);
    +#endif

    return blacklisted;
    }
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-08-05 15:26    [W:4.227 / U:0.280 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site