lkml.org 
[lkml]   [2019]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 39/53] selinux: fix memory leak in policydb_init()
    Date
    From: Ondrej Mosnacek <omosnace@redhat.com>

    commit 45385237f65aeee73641f1ef737d7273905a233f upstream.

    Since roles_init() adds some entries to the role hash table, we need to
    destroy also its keys/values on error, otherwise we get a memory leak in
    the error path.

    Cc: <stable@vger.kernel.org>
    Reported-by: syzbot+fee3a14d4cdf92646287@syzkaller.appspotmail.com
    Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
    Signed-off-by: Ondrej Mosnacek <omosnace@redhat.com>
    Signed-off-by: Paul Moore <paul@paul-moore.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    security/selinux/ss/policydb.c | 6 +++++-
    1 file changed, 5 insertions(+), 1 deletion(-)

    --- a/security/selinux/ss/policydb.c
    +++ b/security/selinux/ss/policydb.c
    @@ -275,6 +275,8 @@ static int rangetr_cmp(struct hashtab *h
    return v;
    }

    +static int (*destroy_f[SYM_NUM]) (void *key, void *datum, void *datap);
    +
    /*
    * Initialize a policy database structure.
    */
    @@ -322,8 +324,10 @@ static int policydb_init(struct policydb
    out:
    hashtab_destroy(p->filename_trans);
    hashtab_destroy(p->range_tr);
    - for (i = 0; i < SYM_NUM; i++)
    + for (i = 0; i < SYM_NUM; i++) {
    + hashtab_map(p->symtab[i].table, destroy_f[i], NULL);
    hashtab_destroy(p->symtab[i].table);
    + }
    return rc;
    }


    \
     
     \ /
      Last update: 2019-08-05 15:26    [W:2.563 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site