lkml.org 
[lkml]   [2019]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] phy: qualcomm: phy-qcom-qmp: Add of_node_put() before return
From
Date
> +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c
> @@ -2094,6 +2094,7 @@ static int qcom_qmp_phy_probe(struct platform_device *pdev)
> dev_err(dev, "failed to create lane%d phy, %d\n",
> id, ret);
> pm_runtime_disable(dev);
> + of_node_put(child);
> return ret;
> }

I suggest to move a bit of common exception handling code to the end of
this function implementation.
Would you like to add a jump target?

Regards,
Markus

\
 
 \ /
  Last update: 2019-08-05 14:12    [W:0.042 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site