Messages in this thread | | | Subject | Re: [PATCH v3] nvme-pci: Support shared tags across queues for Apple 2018 controllers | From | Sagi Grimberg <> | Date | Mon, 5 Aug 2019 13:07:11 -0700 |
| |
>>>>> Ping ? I had another look today and I don't feel like mucking around >>>>> with all the AQ size logic, AEN magic tag etc... just for that sake of >>>>> that Apple gunk. I'm happy to have it give up IO tags, it doesn't seem >>>>> to make much of a difference in practice anyway. >>>>> >>>>> But if you feel strongly about it, then I'll implement the "proper" >>>>> way >>>>> sometimes this week, adding a way to shrink the AQ down to something >>>>> like 3 (one admin request, one async event (AEN), and the empty slot) >>>>> by making a bunch of the constants involved variables instead. >>>> >>>> I don't feel too strongly about it. I think your patch is fine, so >>>> >>>> Acked-by: Keith Busch <keith.busch@intel.com> >>> >>> Should we pick this up for 5.3-rc? >> >> No, it's not a regression fix. Queue it up for 5.4 instead. > > OK, will queue it up for nvme-5.4
Doesn't apply..
Ben, can you please respin a patch that applies on nvme-5.4?
http://git.infradead.org/nvme.git/shortlog/refs/heads/nvme-5.4
| |