lkml.org 
[lkml]   [2019]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] NFC: nfcmrvl: fix gpio-handling regression
From
From: Johan Hovold <johan@kernel.org>
Date: Mon, 5 Aug 2019 12:00:55 +0200

> Fix two reset-gpio sanity checks which were never converted to use
> gpio_is_valid(), and make sure to use -EINVAL to indicate a missing
> reset line also for the UART-driver module parameter and for the USB
> driver.
>
> This specifically prevents the UART and USB drivers from incidentally
> trying to request and use gpio 0, and also avoids triggering a WARN() in
> gpio_to_desc() during probe when no valid reset line has been specified.
>
> Fixes: e33a3f84f88f ("NFC: nfcmrvl: allow gpio 0 for reset signalling")
> Cc: stable <stable@vger.kernel.org> # 4.13
> Reported-by: syzbot+cf35b76f35e068a1107f@syzkaller.appspotmail.com
> Tested-by: syzbot+cf35b76f35e068a1107f@syzkaller.appspotmail.com
> Signed-off-by: Johan Hovold <johan@kernel.org>

Applied and queued up for -stable.

\
 
 \ /
  Last update: 2019-08-05 19:28    [W:0.160 / U:0.420 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site