Messages in this thread | | | Date | Mon, 5 Aug 2019 09:54:44 -0700 | From | Kees Cook <> | Subject | Re: [PATCH v9 01/11] x86/crypto: Adapt assembly for PIE support |
| |
On Mon, Aug 05, 2019 at 06:32:02PM +0200, Borislav Petkov wrote: > On Tue, Jul 30, 2019 at 12:12:45PM -0700, Thomas Garnier wrote: > > Change the assembly code to use only relative references of symbols for the > > kernel to be PIE compatible. > > > > Position Independent Executable (PIE) support will allow to extend the > > KASLR randomization range below 0xffffffff80000000. > > I believe in previous reviews I asked about why this sentence is being > replicated in every commit message and now it is still in every commit > message except in 2/11. > > Why do you need it everywhere and not once in the 0th mail?
I think there was some long-ago feedback from someone (Ingo?) about giving context for the patch so looking at one individually would let someone know that it was part of a larger series. This is a distant memory, though. Do you think it should just be dropped in each patch?
-- Kees Cook
| |