lkml.org 
[lkml]   [2019]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] tpm: tpm_crb: enhance resource mapping mechanism for supporting AMD's fTPM
Hi Seunghun,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on jss-tpmdd/next]
[cannot apply to v5.3-rc6 next-20190830]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Seunghun-Han/Enhance-support-for-the-AMD-s-fTPM/20190901-042313
base: git://git.infradead.org/users/jjs/linux-tpmdd next

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>


coccinelle warnings: (new ones prefixed by >>)

>> drivers/char/tpm/tpm_crb.c:457:29-32: WARNING: Suspicious code. resource_size is maybe missing with res

vim +457 drivers/char/tpm/tpm_crb.c

452
453 static void __iomem *crb_ioremap_resource(struct device *dev,
454 const struct resource *res)
455 {
456 int rc;
> 457 resource_size_t size = res->end - res->start;
458
459 /* Broken BIOS assigns command and response buffers in ACPI NVS region.
460 * Check intersections between a resource and ACPI NVS for W/A.
461 */
462 rc = region_intersects(res->start, size, IORESOURCE_MEM |
463 IORESOURCE_BUSY, IORES_DESC_ACPI_NV_STORAGE);
464 if (rc != REGION_DISJOINT) {
465 dev_err(dev,
466 FW_BUG "Resource overlaps with a ACPI NVS. %pr\n",
467 res);
468 return devm_ioremap(dev, res->start, size);
469 }
470
471 return devm_ioremap_resource(dev, res);
472 }
473

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

\
 
 \ /
  Last update: 2019-09-01 00:28    [W:0.068 / U:2.752 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site