lkml.org 
[lkml]   [2019]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tracing: silence noisy warnings about struct inode
On Sat, 31 Aug 2019 11:46:33 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Thu, 29 Aug 2019 14:34:18 -0700
> Randy Dunlap <rdunlap@infradead.org> wrote:
>
> > From: Randy Dunlap <rdunlap@infradead.org>
> >
> > Fix 30 warnings for missing "struct inode" declaration (like these) by
> > adding a forward reference for it.
> > These warnings come from 'headers_check' (CONFIG_HEADERS_CHECK):
> > CC include/trace/events/iomap.h.s
> >
> > ./../include/trace/events/iomap.h:49:18: warning: 'struct inode' declared inside parameter list will not be visible outside of this definition or declaration
> > ./../include/trace/events/iomap.h:77:18: warning: 'struct inode' declared inside parameter list will not be visible outside of this definition or declaration
> >
> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> > Cc: Steven Rostedt <rostedt@goodmis.org>

Hmm, I don't have this in my tree (I Cc'd Shuah, because I mistaken it as iommu.h.

Please send this to the appropriate maintainer that added this file.

-- Steve

>
> Thanks!
>
> -- Steve
>
> > ---
> > include/trace/events/iomap.h | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > --- linux-next-20190829.orig/include/trace/events/iomap.h
> > +++ linux-next-20190829/include/trace/events/iomap.h
> > @@ -44,6 +44,8 @@ DECLARE_EVENT_CLASS(iomap_page_class,
> > __entry->length)
> > )
> >
> > +struct inode;
> > +
> > #define DEFINE_PAGE_EVENT(name) \
> > DEFINE_EVENT(iomap_page_class, name, \
> > TP_PROTO(struct inode *inode, struct page *page, unsigned long off, \
>

\
 
 \ /
  Last update: 2019-08-31 17:49    [W:0.097 / U:0.496 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site