lkml.org 
[lkml]   [2019]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH -next] PCI: Use GFP_ATOMIC in resource_alignment_store()
    Date
    When allocating memory, the GFP_KERNEL cannot be used during the
    spin_lock period. It may cause scheduling when holding spin_lock.

    Fixes: f13755318675 ("PCI: Move pci_[get|set]_resource_alignment_param() into their callers")
    Signed-off-by: YueHaibing <yuehaibing@huawei.com>
    ---
    drivers/pci/pci.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
    index 484e35349565..0b5fc6736f3f 100644
    --- a/drivers/pci/pci.c
    +++ b/drivers/pci/pci.c
    @@ -6148,7 +6148,7 @@ static ssize_t resource_alignment_store(struct bus_type *bus,
    spin_lock(&resource_alignment_lock);

    kfree(resource_alignment_param);
    - resource_alignment_param = kstrndup(buf, count, GFP_KERNEL);
    + resource_alignment_param = kstrndup(buf, count, GFP_ATOMIC);

    spin_unlock(&resource_alignment_lock);


    \
     
     \ /
      Last update: 2019-08-31 14:46    [W:5.942 / U:0.344 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site