lkml.org 
[lkml]   [2019]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 06/11] wimax/i2400m: remove unlikely() from WARN*() condition
From
Date
>  		pad_buf = i2400m_tx_fifo_push(i2400m, padding, 0, 0);
> - if (unlikely(WARN_ON(pad_buf == NULL
> - || pad_buf == TAIL_FULL))) {
> + if (WARN_ON(pad_buf == NULL || pad_buf == TAIL_FULL)) {

How do you think about to use the following code variant?

+ if (WARN_ON(!pad_buf || pad_buf == TAIL_FULL)) {


Regards,
Markus

\
 
 \ /
  Last update: 2019-08-31 13:27    [W:0.604 / U:1.984 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site