lkml.org 
[lkml]   [2019]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [alsa-devel] [PATCH 2/3] ASoC: es8316: Add clock control of MCLK
From
Date
Hello Mark,

On 2019/08/30 20:18, Mark Brown wrote:
> On Fri, Aug 30, 2019 at 02:32:04AM +0900, Katsuhiro Suzuki wrote:
>
>> + es8316->mclk = devm_clk_get(component->dev, "mclk");
>> + if (PTR_ERR(es8316->mclk) == -EPROBE_DEFER)
>> + return -EPROBE_DEFER;
>
> If we don't get a clock it'd be nice to at least log that in case
> there's something wrong with the clock driver so that people have more
> of a hint as to why things might be breaking.
>

OK, to change more user friendly.


>> +
>> + if (es8316->mclk) {
>> + ret = clk_prepare_enable(es8316->mclk);
>> + if (ret)
>> + return ret;
>> + }
>> +
>
> There's nothing that disables the clock on remove.
>
> Otherwise this looks good.
>
Thank you for reviewing. I'll fix it and send V2 patch set.


>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>

Best Regards,
Katsuhiro Suzuki

\
 
 \ /
  Last update: 2019-08-31 13:20    [W:0.115 / U:10.976 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site