Messages in this thread | | | Date | Fri, 30 Aug 2019 13:47:28 -0700 | From | Kees Cook <> | Subject | Re: [PATCH] asm-generic: add unlikely to default BUG_ON(x) |
| |
On Fri, Aug 30, 2019 at 10:08:49PM +0200, Arnd Bergmann wrote: > On Wed, Aug 28, 2019 at 11:09 PM Denis Efremov <efremov@linux.com> wrote: > > > > Add unlikely to default BUG_ON(x) in !CONFIG_BUG. It makes > > the define consistent with BUG_ON(x) in CONFIG_BUG. > > > > Signed-off-by: Denis Efremov <efremov@linux.com> > > Cc: Arnd Bergmann <arnd@arndb.de> > > Cc: <linux-arch@vger.kernel.org> > > This makes sense, I've applied it to the asm-generic tree for now. > > Two concerns though: > > - adding unlikely() can cause new (usually false-postive) compile time > warnings to show up in random configurations, so we'll have to see what > the build bots think > > - Kees Cook has recently sent a series for asm/bug.h that was merged by > Andrew Morton. If there are is a conflict with your patch, it may be better > to merge both through the same tree, either linux-mm or asm-generic.
FWIW, this patch looks sensible to me. :)
Reviewed-by: Kees Cook <keescook@chromium.org>
-- Kees Cook
| |