Messages in this thread | | | Date | Fri, 30 Aug 2019 14:31:09 -0500 | From | Josh Poimboeuf <> | Subject | Re: [PATCH 0/4] objtool,perf: Use shared x86 insn decoder |
| |
On Fri, Aug 30, 2019 at 04:00:58PM -0300, Arnaldo Carvalho de Melo wrote: > I.e. we need to make sure that it always gets the x86 stuff, not > something that is tied to the host arch, with the patch below we get it > to work, please take a look. > > Probably this should go to the master copy, i.e. to the kernel sources, > no? > > That or we'll have to ask the check-headers.sh and objtool sync-check > (hey, this should be unified, each project could provide just the list > of things it uses, but I digress) to ignore those lines... > > I.e. we want to decode intel_PT traces on other arches, ditto for > CoreSight (not affected here, but similar concept). > > will kick the full container build process now.
Interesting, I didn't realize other arches would be using it. The patch looks good to me.
Ideally there wouldn't be any differences between the headers, but if that's unavoidable then I guess we can just use the same 'diff -I' trick we were using before in the check script(s).
-- Josh
| |