lkml.org 
[lkml]   [2019]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] soundwire: slave: Fix unused function warning on !ACPI
From
Date
On 8/30/19 11:52 AM, Michal Suchanek wrote:
> Fixes the following warning on !ACPI systems:
>
> drivers/soundwire/slave.c:16:12: warning: ‘sdw_slave_add’ defined but
> not used [-Wunused-function]
> static int sdw_slave_add(struct sdw_bus *bus,
> ^~~~~~~~~~~~~
>
> Signed-off-by: Michal Suchanek <msuchanek@suse.de>

Acked-by: Randy Dunlap <rdunlap@infradead.org>

I was about to send the same patch.
Thanks.

> ---
> drivers/soundwire/slave.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soundwire/slave.c b/drivers/soundwire/slave.c
> index f39a5815e25d..34c7e65831d1 100644
> --- a/drivers/soundwire/slave.c
> +++ b/drivers/soundwire/slave.c
> @@ -6,6 +6,7 @@
> #include <linux/soundwire/sdw_type.h>
> #include "bus.h"
>
> +#if IS_ENABLED(CONFIG_ACPI)
> static void sdw_slave_release(struct device *dev)
> {
> struct sdw_slave *slave = dev_to_sdw_dev(dev);
> @@ -60,7 +61,6 @@ static int sdw_slave_add(struct sdw_bus *bus,
> return ret;
> }
>
> -#if IS_ENABLED(CONFIG_ACPI)
> /*
> * sdw_acpi_find_slaves() - Find Slave devices in Master ACPI node
> * @bus: SDW bus instance
>


--
~Randy

\
 
 \ /
  Last update: 2019-08-30 20:57    [W:0.092 / U:0.916 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site