Messages in this thread | | | Date | Sat, 31 Aug 2019 00:04:25 +0530 | From | Sibi Sankar <> | Subject | Re: [RESEND PATCH v2 1/2] dt-bindings: reset: aoss: Add AOSS reset binding for SC7180 SoCs |
| |
Hey Stephen, Thanks for the review!
On 2019-08-30 11:02, Stephen Boyd wrote: > Quoting Sibi Sankar (2019-08-24 08:24:10) >> Add SC7180 AOSS reset to the list of possible bindings. >> >> Signed-off-by: Sibi Sankar <sibis@codeaurora.org> >> --- >> Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt | 4 ++-- > > Can you convert this binding to YAML/JSON schema? Would help to > describe > the 'one of' requirement below in a more structured way.
yeah converting them shouldn't take time but 'oneof' isn't the requirement here. We want to specify that sc7180 should continue to use the sdm845 compatible since the offset/ num of reset are identical.
> >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git >> a/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt >> b/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt >> index 510c748656ec5..3eb6a22ced4bc 100644 >> --- a/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt >> +++ b/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt >> @@ -8,8 +8,8 @@ Required properties: >> - compatible: >> Usage: required >> Value type: <string> >> - Definition: must be: >> - "qcom,sdm845-aoss-cc" >> + Definition: must be one of:
-- -- Sibi Sankar -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
| |