| From | David Howells <> | Subject | Re: [PATCH V40 04/29] lockdown: Enforce module signatures if the kernel is locked down | Date | Fri, 30 Aug 2019 17:31:13 +0100 |
| |
Matthew Garrett <matthewgarrett@google.com> wrote:
> enum lockdown_reason { > LOCKDOWN_NONE, > + LOCKDOWN_MODULE_SIGNATURE, > LOCKDOWN_INTEGRITY_MAX, > LOCKDOWN_CONFIDENTIALITY_MAX, > };
Aren't you mixing disjoint sets?
> + [LOCKDOWN_MODULE_SIGNATURE] = "unsigned module loading",
Wouldn't it be better to pass this string as a parameter to security_locked_down()?
David
|