Messages in this thread | | | Date | Fri, 30 Aug 2019 16:04:30 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v3 10/10] lib/test_printf: Add tests for %pfw printk modifier |
| |
On Thu, Aug 29, 2019 at 01:10:43PM +0300, Sakari Ailus wrote: > Add a test for the %pfw printk modifier using software nodes. >
Having tests is always a good thing! Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> > --- > lib/test_printf.c | 37 +++++++++++++++++++++++++++++++++++++ > 1 file changed, 37 insertions(+) > > diff --git a/lib/test_printf.c b/lib/test_printf.c > index 944eb50f38625..9c6d716979fb1 100644 > --- a/lib/test_printf.c > +++ b/lib/test_printf.c > @@ -22,6 +22,8 @@ > #include <linux/gfp.h> > #include <linux/mm.h> > > +#include <linux/property.h> > + > #include "../tools/testing/selftests/kselftest_module.h" > > #define BUF_SIZE 256 > @@ -588,6 +590,40 @@ flags(void) > kfree(cmp_buffer); > } > > +static void __init fwnode_pointer(void) > +{ > + const struct software_node softnodes[] = { > + { .name = "first", }, > + { .name = "second", .parent = &softnodes[0], }, > + { .name = "third", .parent = &softnodes[1], }, > + { NULL /* Guardian */ }, > + }; > + const char * const full_name = "/second/third"; > + const char * const full_name_second = "/second"; > + const char * const second_name = "second"; > + const char * const third_name = "third"; > + int rval; > + > + rval = software_node_register_nodes(softnodes); > + if (rval) { > + pr_warn("cannot register softnodes; rval %d\n", rval); > + return; > + } > + > + test(full_name_second, "%pfw", > + software_node_fwnode(&softnodes[ARRAY_SIZE(softnodes) - 3])); > + test(full_name, "%pfw", > + software_node_fwnode(&softnodes[ARRAY_SIZE(softnodes) - 2])); > + test(full_name, "%pfwf", > + software_node_fwnode(&softnodes[ARRAY_SIZE(softnodes) - 2])); > + test(second_name, "%pfwP", > + software_node_fwnode(&softnodes[ARRAY_SIZE(softnodes) - 3])); > + test(third_name, "%pfwP", > + software_node_fwnode(&softnodes[ARRAY_SIZE(softnodes) - 2])); > + > + software_node_unregister_nodes(softnodes); > +} > + > static void __init > test_pointer(void) > { > @@ -610,6 +646,7 @@ test_pointer(void) > bitmap(); > netdev_features(); > flags(); > + fwnode_pointer(); > } > > static void __init selftest(void) > -- > 2.20.1 >
-- With Best Regards, Andy Shevchenko
| |