Messages in this thread | | | Date | Sat, 31 Aug 2019 12:03:26 +0900 | From | Namhyung Kim <> | Subject | Re: [PATCH 2/9] perf/core: Add PERF_SAMPLE_CGROUP feature |
| |
Hi Tejun,
On Wed, Aug 28, 2019 at 07:49:11AM -0700, Tejun Heo wrote: > On Wed, Aug 28, 2019 at 04:31:23PM +0900, Namhyung Kim wrote: > > @@ -958,6 +958,7 @@ struct perf_sample_data { > > u64 stack_user_size; > > > > u64 phys_addr; > > + u64 cgroup; > > Ditto, please use fhandle as the identifier.
Hmm.. it looks hard to use fhandle as the identifier since perf sampling is done in NMI context. AFAICS the encode_fh part seems ok but getting dentry/inode from a kernfs_node seems not.
I assume kernfs_node_id's ino and gen are same to its inode's. Then we might use kernfs_node for encoding but not sure you like it ;-)
Thanks Namhyung
| |