Messages in this thread | | | From | Dexuan Cui <> | Subject | RE: [PATCH v3 10/12] Drivers: hv: vmbus: Clean up hv_sock channels by force upon suspend | Date | Sat, 31 Aug 2019 02:00:56 +0000 |
| |
> From: Michael Kelley <mikelley@microsoft.com> > Sent: Friday, August 23, 2019 1:02 PM > > From: Dexuan Cui Sent: Monday, August 19, 2019 6:52 PM > > > > Fake RESCIND_CHANNEL messages to clean up hv_sock channels by force for > > hibernation. There is no better method to clean up the channels since > > some of the channels may still be referenced by the userspace apps when > > hiberantin is triggered: in this case, the "rescind" fields of the > > s/hiberantin/hibernation/
Thanks! Will fix this in v4.
> > @@ -2091,6 +2127,25 @@ static int vmbus_acpi_add(struct acpi_device > *device) > > > > static int vmbus_bus_suspend(struct device *dev) > > { > > + struct vmbus_channel *channel; > > + > > + while (atomic_read(&vmbus_connection.offer_in_progress) != 0) { > > + /* > > + * We wait here until any channel offer is currently > > + * being processed. > > + */ > > The wording of the comment is a bit off. Maybe > > /* > * We wait here until the completion of any channel > * offers that are currently in progress. > */
Will use the better version this in v4.
Thanks, -- Dexuan
| |