Messages in this thread | | | Subject | Re: [PATCH] isdn: hysdn: Fix error spaces around '*' | From | Joe Perches <> | Date | Sat, 03 Aug 2019 04:15:05 -0700 |
| |
On Sat, 2019-08-03 at 08:32 +0200, Greg KH wrote: > On Fri, Aug 02, 2019 at 07:56:02PM +0000, Jose Carlos Cazarin Filho wrote: > > Fix checkpath error: > > CHECK: spaces preferred around that '*' (ctx:WxV) > > +extern hysdn_card *card_root; /* pointer to first card */ [] > > diff --git a/drivers/staging/isdn/hysdn/hysdn_defs.h b/drivers/staging/isdn/hysdn/hysdn_defs.h [] > > @@ -220,7 +220,7 @@ typedef struct hycapictrl_info hycapictrl_info; > > /*****************/ > > /* exported vars */ > > /*****************/ > > -extern hysdn_card *card_root; /* pointer to first card */ > > +extern hysdn_card * card_root; /* pointer to first card */ > > The original code here is correct, checkpatch must be reporting this > incorrectly.
Here checkpatch thinks that hydsn_card is an identifier rather than a typedef.
It's defined as: typedef struct HYSDN_CARD { ... } hysdn_card;
And that confuses checkpatch.
kernel source code style would not use a typedef for a struct.
A change would be to remove the typedef and declare this as: struct hysdn_card { ... };
And then do a global: sed 's/\bhysdn_card\b/struct hysdn_card/g'
But that's not necessary as the driver is likely to be removed.
| |