lkml.org 
[lkml]   [2019]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v1] cpuidle-haltpoll: vcpu hotplug support
From
Date
On 8/29/19 12:56 PM, Marcelo Tosatti wrote:
> Hi Joao,
>
> On Wed, Aug 28, 2019 at 07:56:50PM +0100, Joao Martins wrote:
>> +static void haltpoll_uninit(void)
>> +{
>> + unsigned int cpu;
>> +
>> + cpus_read_lock();
>> +
>> + for_each_online_cpu(cpu) {
>> + struct cpuidle_device *dev =
>> + per_cpu_ptr(haltpoll_cpuidle_devices, cpu);
>> +
>> + if (!dev->registered)
>> + continue;
>> +
>> + arch_haltpoll_disable(cpu);
>> + cpuidle_unregister_device(dev);
>> + }
>
> 1)
>
>> +
>> + cpuidle_unregister(&haltpoll_driver);
>
> cpuidle_unregister_driver.

Will fix -- this was an oversight.

>
>> + free_percpu(haltpoll_cpuidle_devices);
>> + haltpoll_cpuidle_devices = NULL;
>> +
>> + cpus_read_unlock();
>
> Any reason you can't cpus_read_unlock() at 1) ?
>
No, let me adjust that too.

> Looks good otherwise.
>
> Thanks!
>
Thanks for the review!

Joao

\
 
 \ /
  Last update: 2019-08-29 15:52    [W:0.051 / U:8.416 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site