lkml.org 
[lkml]   [2019]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 1/2] net: core: Notify on changes to dev->promiscuity.
    On Thu, 29 Aug 2019 15:15:43 +0200
    Andrew Lunn <andrew@lunn.ch> wrote:

    > The problem with this is, the driver only gets called when promisc
    > goes from 0 to !0. So, the port is added to the bridge. Promisc goes
    > 0->1, and the driver gets called. We can evaluate as you said above,
    > and leave the port filtering frames, not forwarding everything. When
    > tcpdump is started, the core does promisc 1->2, but does not call into
    > the driver. Also, currently sending a notification is not
    > unconditional.

    Hi Andrew,

    got it. What about to change the existing notify call so NETDEV_CHANGE
    notification will be also sent when (old_promiscuity !=
    new_promiscuity)?

    Ivan

    \
     
     \ /
      Last update: 2019-08-29 15:40    [W:5.014 / U:0.208 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site