Messages in this thread Patch in this message | | | From | Felipe Balbi <> | Subject | [PATCH v2 2/2] PTP: add support for one-shot output | Date | Thu, 29 Aug 2019 12:58:25 +0300 |
| |
Some controllers allow for a one-shot output pulse, in contrast to periodic output. Now that we have extensible versions of our IOCTLs, we can finally make use of the 'flags' field to pass a bit telling driver that if we want one-shot pulse output.
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com> ---
Changes since v1: - remove comment from .flags field
drivers/ptp/ptp_chardev.c | 5 ++--- include/uapi/linux/ptp_clock.h | 4 +++- 2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/ptp/ptp_chardev.c b/drivers/ptp/ptp_chardev.c index 98ec1395544e..a407e5f76e2d 100644 --- a/drivers/ptp/ptp_chardev.c +++ b/drivers/ptp/ptp_chardev.c @@ -177,9 +177,8 @@ long ptp_ioctl(struct posix_clock *pc, unsigned int cmd, unsigned long arg) err = -EFAULT; break; } - if ((req.perout.flags || req.perout.rsv[0] || req.perout.rsv[1] - || req.perout.rsv[2] || req.perout.rsv[3]) - && cmd == PTP_PEROUT_REQUEST2) { + if ((req.perout.rsv[0] || req.perout.rsv[1] || req.perout.rsv[2] + || req.perout.rsv[3]) && cmd == PTP_PEROUT_REQUEST2) { err = -EINVAL; break; } else if (cmd == PTP_PEROUT_REQUEST) { diff --git a/include/uapi/linux/ptp_clock.h b/include/uapi/linux/ptp_clock.h index 039cd62ec706..95840e5f5c53 100644 --- a/include/uapi/linux/ptp_clock.h +++ b/include/uapi/linux/ptp_clock.h @@ -67,7 +67,9 @@ struct ptp_perout_request { struct ptp_clock_time start; /* Absolute start time. */ struct ptp_clock_time period; /* Desired period, zero means disable. */ unsigned int index; /* Which channel to configure. */ - unsigned int flags; /* Reserved for future use. */ + +#define PTP_PEROUT_ONE_SHOT BIT(0) + unsigned int flags; unsigned int rsv[4]; /* Reserved for future use. */ }; -- 2.23.0
| |