lkml.org 
[lkml]   [2019]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] net: spider_net: Use struct_size() helper
From
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Date: Wed, 28 Aug 2019 15:21:08 -0500

> One of the more common cases of allocation size calculations is finding
> the size of a structure that has a zero-sized array at the end, along
> with memory for some number of elements for that array. For example:
>
> struct spider_net_card {
> ...
> struct spider_net_descr darray[0];
> };
>
> Make use of the struct_size() helper instead of an open-coded version
> in order to avoid any potential type mistakes.
>
> So, replace the following form:
>
> sizeof(struct spider_net_card) + (tx_descriptors + rx_descriptors) * sizeof(struct spider_net_descr)
>
> with:
>
> struct_size(card, darray, tx_descriptors + rx_descriptors)
>
> Notice that, in this case, variable alloc_size is not necessary, hence it
> is removed.
>
> Building: allmodconfig powerpc.
>
> This code was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

Applied to net-next, thanks.

\
 
 \ /
  Last update: 2019-08-30 02:54    [W:0.595 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site