lkml.org 
[lkml]   [2019]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] xfs: Use WARN_ON_ONCE rather than BUG for bailout mount-operation
    If the CONFIG_BUG is enabled, BUG is executed and then system is crashed.
    However, the bailout for mount is no longer proceeding.

    For this reason, using WARN_ON_ONCE rather than BUG can prevent this situation.

    Signed-off-by: Austin Kim <austindh.kim@gmail.com>
    ---
    fs/xfs/xfs_mount.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/fs/xfs/xfs_mount.c b/fs/xfs/xfs_mount.c
    index 322da69..c0d0b72 100644
    --- a/fs/xfs/xfs_mount.c
    +++ b/fs/xfs/xfs_mount.c
    @@ -213,8 +213,7 @@ xfs_initialize_perag(
    goto out_hash_destroy;

    spin_lock(&mp->m_perag_lock);
    - if (radix_tree_insert(&mp->m_perag_tree, index, pag)) {
    - BUG();
    + if (WARN_ON_ONCE(radix_tree_insert(&mp->m_perag_tree, index, pag))) {
    spin_unlock(&mp->m_perag_lock);
    radix_tree_preload_end();
    error = -EEXIST;
    --
    2.6.2
    \
     
     \ /
      Last update: 2019-08-30 02:31    [W:3.201 / U:0.928 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site