Messages in this thread | | | Date | Thu, 29 Aug 2019 15:42:21 -0700 (PDT) | From | Stefano Stabellini <> | Subject | Re: [PATCH 05/11] xen: remove the exports for xen_{create,destroy}_contiguous_region |
| |
On Mon, 26 Aug 2019, Christoph Hellwig wrote: > These routines are only used by swiotlb-xen, which cannot be modular. > > Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> --- > arch/arm/xen/mm.c | 2 -- > arch/x86/xen/mmu_pv.c | 2 -- > 2 files changed, 4 deletions(-) > > diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c > index 9b3a6c0ca681..b7d53415532b 100644 > --- a/arch/arm/xen/mm.c > +++ b/arch/arm/xen/mm.c > @@ -155,13 +155,11 @@ int xen_create_contiguous_region(phys_addr_t pstart, unsigned int order, > *dma_handle = pstart; > return 0; > } > -EXPORT_SYMBOL_GPL(xen_create_contiguous_region); > > void xen_destroy_contiguous_region(phys_addr_t pstart, unsigned int order) > { > return; > } > -EXPORT_SYMBOL_GPL(xen_destroy_contiguous_region); > > int __init xen_mm_init(void) > { > diff --git a/arch/x86/xen/mmu_pv.c b/arch/x86/xen/mmu_pv.c > index 26e8b326966d..c8dbee62ec2a 100644 > --- a/arch/x86/xen/mmu_pv.c > +++ b/arch/x86/xen/mmu_pv.c > @@ -2625,7 +2625,6 @@ int xen_create_contiguous_region(phys_addr_t pstart, unsigned int order, > *dma_handle = virt_to_machine(vstart).maddr; > return success ? 0 : -ENOMEM; > } > -EXPORT_SYMBOL_GPL(xen_create_contiguous_region); > > void xen_destroy_contiguous_region(phys_addr_t pstart, unsigned int order) > { > @@ -2660,7 +2659,6 @@ void xen_destroy_contiguous_region(phys_addr_t pstart, unsigned int order) > > spin_unlock_irqrestore(&xen_reservation_lock, flags); > } > -EXPORT_SYMBOL_GPL(xen_destroy_contiguous_region); > > static noinline void xen_flush_tlb_all(void) > { > -- > 2.20.1 >
| |