lkml.org 
[lkml]   [2019]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.4 12/15] Tools: hv: kvp: eliminate 'may be used uninitialized' warning
    Date
    From: Vitaly Kuznetsov <vkuznets@redhat.com>

    [ Upstream commit 89eb4d8d25722a0a0194cf7fa47ba602e32a6da7 ]

    When building hv_kvp_daemon GCC-8.3 complains:

    hv_kvp_daemon.c: In function ‘kvp_get_ip_info.constprop’:
    hv_kvp_daemon.c:812:30: warning: ‘ip_buffer’ may be used uninitialized in this function [-Wmaybe-uninitialized]
    struct hv_kvp_ipaddr_value *ip_buffer;

    this seems to be a false positive: we only use ip_buffer when
    op == KVP_OP_GET_IP_INFO and it is only unset when op == KVP_OP_ENUMERATE.

    Silence the warning by initializing ip_buffer to NULL.

    Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    tools/hv/hv_kvp_daemon.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c
    index 1774800668168..a3ac283a985ae 100644
    --- a/tools/hv/hv_kvp_daemon.c
    +++ b/tools/hv/hv_kvp_daemon.c
    @@ -878,7 +878,7 @@ kvp_get_ip_info(int family, char *if_name, int op,
    int sn_offset = 0;
    int error = 0;
    char *buffer;
    - struct hv_kvp_ipaddr_value *ip_buffer;
    + struct hv_kvp_ipaddr_value *ip_buffer = NULL;
    char cidr_mask[5]; /* /xyz */
    int weight;
    int i;
    --
    2.20.1
    \
     
     \ /
      Last update: 2019-08-29 20:19    [W:4.664 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site