Messages in this thread | | | Subject | Re: [PATCH v2] scripts: coccinelle: check for !(un)?likely usage | From | Denis Efremov <> | Date | Thu, 29 Aug 2019 20:13:05 +0300 |
| |
On 8/29/19 8:10 PM, Denis Efremov wrote: > This patch adds coccinelle script for detecting !likely and > !unlikely usage. These notations are confusing. It's better > to replace !likely(x) with unlikely(!x) and !unlikely(x) with > likely(!x) for readability.
I'm not sure that this rule deserves the acceptance. Just to want to be sure that "!unlikely(x)" and "!likely(x)" are hard-readable is not only my perception and that they become more clear in form "likely(!x)" and "unlikely(!x)" too.
Thanks, Denis
| |