lkml.org 
[lkml]   [2019]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 04/11] xen/events: Remove unlikely() from WARN() condition
    Date
    "unlikely(WARN(x))" is excessive. WARN() already uses unlikely()
    internally.

    Signed-off-by: Denis Efremov <efremov@linux.com>
    Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
    Cc: Juergen Gross <jgross@suse.com>
    Cc: Joe Perches <joe@perches.com>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    Cc: xen-devel@lists.xenproject.org
    ---
    drivers/xen/events/events_base.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/xen/events/events_base.c b/drivers/xen/events/events_base.c
    index 2e8570c09789..6c8843968a52 100644
    --- a/drivers/xen/events/events_base.c
    +++ b/drivers/xen/events/events_base.c
    @@ -247,7 +247,7 @@ static void xen_irq_info_cleanup(struct irq_info *info)
    */
    unsigned int evtchn_from_irq(unsigned irq)
    {
    - if (unlikely(WARN(irq >= nr_irqs, "Invalid irq %d!\n", irq)))
    + if (WARN(irq >= nr_irqs, "Invalid irq %d!\n", irq))
    return 0;

    return info_for_irq(irq)->evtchn;
    --
    2.21.0
    \
     
     \ /
      Last update: 2019-08-29 18:51    [W:2.729 / U:0.232 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site