Messages in this thread | | | Date | Wed, 28 Aug 2019 08:42:31 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH] x86/cpufeature: explicit comments for duplicate macro |
| |
On Wed, Aug 28, 2019 at 02:11:00PM +0800, Cao jin wrote:
For the future:
> Subject: Re: [PATCH] x86/cpufeature: explicit comments for duplicate macro
your subject needs to have a verb and start with a capital letter after the subsystem/path prefix. In this case, something like this, for example:
Subject: [PATCH] x86/cpufeature: Explain the macro duplication
> Help people to understand the author's intent of apparent duplication of > BUILD_BUG_ON_ZERO(NCAPINTS != n), which is hard to detect by eyes. > > CC: Dave Hansen <dave.hansen@intel.com> > Suggested-by: Borislav Petkov <bp@alien8.de> > Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com> > --- > Tried my best to describe it accurately, in case of any inaccuracy, feel > free to rephrase.
Yap, I fixed it up.
Thanks!
-- Regards/Gruss, Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
| |