Messages in this thread | | | From | Fabio Estevam <> | Date | Wed, 28 Aug 2019 13:02:32 -0300 | Subject | Re: [PATCH] ASoC: fsl_ssi: Fix clock control issue in master mode |
| |
Hi Shengjiu,
On Wed, Aug 28, 2019 at 2:21 AM Shengjiu Wang <shengjiu.wang@nxp.com> wrote: > > The test case is > arecord -Dhw:0 -d 10 -f S16_LE -r 48000 -c 2 temp.wav & > aplay -Dhw:0 -d 30 -f S16_LE -r 48000 -c 2 test.wav > > There will be error after end of arecord: > aplay: pcm_write:2051: write error: Input/output error > > Capture and Playback work in parallel in master mode, one > substream stops, the other substream is impacted, the > reason is that clock is disabled wrongly. > > The clock's reference count is not increased when second > substream starts, the hw_param() function returns in the > beginning because first substream is enabled, then in end > of first substream, the hw_free() disables the clock. > > This patch is to move the clock enablement to the place > before checking of the device enablement in hw_param(). > > Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
It would be nice if you could add a Fixes tag as well.
| |