Messages in this thread | | | Date | Wed, 28 Aug 2019 11:10:28 +0200 | From | Thierry Reding <> | Subject | Re: [PATCH 0/6] PCI: tegra: Enable PCIe C5 controller of Tegra194 in p2972-0000 platform |
| |
On Mon, Aug 26, 2019 at 01:01:37PM +0530, Vidya Sagar wrote: > This patch series enables Tegra194's C5 controller which owns x16 slot in > p2972-0000 platform. C5 controller's PERST# and CLKREQ# are not configured as > output and bi-directional signals by default and hence they need to be > configured explicitly. Also, x16 slot's 3.3V and 12V supplies are controlled > through GPIOs and hence they need to be enabled through regulator framework. > This patch series adds required infrastructural support to address both the > aforementioned requirements. > Testing done on p2972-0000 platform > - Able to enumerate devices connected to x16 slot (owned by C5 controller) > - Enumerated device's functionality verified > - Suspend-Resume sequence is verified with device connected to x16 slot > > Vidya Sagar (6): > dt-bindings: PCI: tegra: Add sideband pins configuration entries > arm64: tegra: Add configuration for PCIe C5 sideband signals > PCI: tegra: Add support to configure sideband pins > dt-bindings: PCI: tegra: Add PCIe slot supplies regulator entries > arm64: tegra: Add PCIe slot supply information in p2972-0000 platform > PCI: tegra: Add support to enable slot regulators
Hi Vidya,
when you resend with review comments addressed, can you please reorder the patches slightly? I think it's more natural to order them like this:
dt-bindings: PCI: tegra: Add sideband pins configuration entries PCI: tegra: Add support to configure sideband pins dt-bindings: PCI: tegra: Add PCIe slot supplies regulator entries PCI: tegra: Add support to enable slot regulators arm64: tegra: Add configuration for PCIe C5 sideband signals arm64: tegra: Add PCIe slot supply information in p2972-0000 platform
Or perhaps even like this:
dt-bindings: PCI: tegra: Add sideband pins configuration entries dt-bindings: PCI: tegra: Add PCIe slot supplies regulator entries PCI: tegra: Add support to configure sideband pins PCI: tegra: Add support to enable slot regulators arm64: tegra: Add configuration for PCIe C5 sideband signals arm64: tegra: Add PCIe slot supply information in p2972-0000 platform
That makes it more obvious that patches 1-2 need an Acked-by from Rob and patches 1-4 need to go through Lorenzo's tree and that I'll pick up patches 5-6.
Thierry [unhandled content-type:application/pgp-signature] | |