lkml.org 
[lkml]   [2019]   [Aug]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH V3 1/5] thermal: qoriq: Add clock operations
    Date
    Hi, Rui

    > On Tue, 2019-08-27 at 12:41 +0000, Leonard Crestez wrote:
    > > On 27.08.2019 04:51, Anson Huang wrote:
    > > > > In an earlier series the CLK_IS_CRITICAL flags was removed from
    > > > > the TMU clock so if the thermal driver doesn't explicitly enable
    > > > > it the system will hang on probe. This is what happens in
    > > > > linux-next right now!
    > > >
    > > > The thermal driver should be built with module, so default kernel
    > > > should can boot up, do you modify the thermal driver as built-in?
    > > >
    > > > > Unless this patches is merged soon we'll end up with a 5.4-rc1
    > > > > that doesn't boot on imx8mq. An easy fix would be to drop/revert
    > > > > commit
    > > > > 951c1aef9691 ("clk: imx8mq: Remove CLK_IS_CRITICAL flag for
    > > > > IMX8MQ_CLK_TMU_ROOT") until the thermal patches are accepted.
    > > >
    > > > If the thermal driver is built as module, I think no need to revert
    > > > the commit, but if by default thermal driver is built-in or mod
    > > > probed, then yes, it should NOT break kernel boot up.
    > >
    > > The qoriq_thermal driver is built as a module in defconfig and when
    > > modules are properly installed in rootfs they will be automatically be
    > > probed on boot and cause a hang.
    > >
    > > I usually run nfsroot with modules:
    > >
    > > make modules_install INSTALL_MOD_PATH=/srv/nfs/imx8-root
    >
    > so we need this patch shipped in the beginning of the merge window, right?
    > if there is hard dependency between patches, it's better to send them in one
    > series, and get shipped via either tree.

    There is no hard dependency in this patch series. Previous for the TMU clock disabled
    patch, since thermal driver is built as module so I did NOT found the issue. The patch
    series is the correct fix.

    Thanks,
    Anson

    >
    > BTW, who is maintaining qoriq driver from NXP? If Anson is maintaining and
    > developing this driver, it's better to update this in the driver or the
    > MAINTAINER file, I will take the driver specific patches as long as we have
    > ACK/Reviewed-By from the driver maintainer.
    >
    > thanks,
    > rui
    >
    > >
    > > --
    > > Regards,
    > > Leonard

    \
     
     \ /
      Last update: 2019-08-28 10:53    [W:2.693 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site