Messages in this thread | | | From | Felipe Balbi <> | Subject | Re: [PATCH 1/2] PTP: introduce new versions of IOCTLs | Date | Wed, 28 Aug 2019 11:23:33 +0300 |
| |
Hi,
Joe Perches <joe@perches.com> writes:
> On Mon, 2019-08-19 at 08:43 -0700, Richard Cochran wrote: >> On Sun, Aug 18, 2019 at 03:07:18PM -0700, Joe Perches wrote: >> > Also the original patch deletes 2 case entries for >> > PTP_PIN_GETFUNC and PTP_PIN_SETFUNC and converts them to >> > PTP_PIN_GETFUNC2 and PTP_PIN_SETFUNC2 but still uses tests >> > for the deleted case label entries making part of the case >> > code block unreachable. >> > >> > That's at least a defect: >> > >> > - case PTP_PIN_GETFUNC: >> > + case PTP_PIN_GETFUNC2: >> > >> > and >> > >> > - case PTP_PIN_SETFUNC: >> > + case PTP_PIN_SETFUNC2: >> >> Good catch. Felipe, please fix that! >> >> (Regarding Joe's memset suggestion, I'll leave that to your discretion.) > > Not just how declarations are done or memset. > > Minimizing unnecessary stack consumption is generally good.
Originally I had memset only on the three cases where they were needed. Richard, which do you prefer? I don't mind changing it back.
-- balbi [unhandled content-type:application/pgp-signature]
| |