Messages in this thread | | | Date | Thu, 29 Aug 2019 10:09:35 +0800 | From | Peter Xu <> | Subject | Re: [PATCH 4/4] KVM: selftests: Remove duplicate guest mode handling |
| |
On Wed, Aug 28, 2019 at 01:46:13PM +0200, Andrew Jones wrote:
[...]
> > +unsigned int vm_get_page_size(struct kvm_vm *vm) > > +{ > > + return vm->page_size; > > +} > > + > > +unsigned int vm_get_page_shift(struct kvm_vm *vm) > > +{ > > + return vm->page_shift; > > +} > > We could get by with just one of the above two, but whatever
Right... and imho if we export kvm_vm struct we don't even any helpers. :) But I didn't touch that.
> > + > > +unsigned int vm_get_max_gfn(struct kvm_vm *vm) > > +{ > > + return vm->max_gfn; > > +} > > -- > > 2.21.0 > > > > Reviewed-by: Andrew Jones <drjones@redhat.com>
Thanks!
-- Peter Xu
| |