lkml.org 
[lkml]   [2019]   [Aug]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/4] KVM: selftests: Move vm type into _vm_create() internally
On Wed, Aug 28, 2019 at 01:23:57PM +0200, Andrew Jones wrote:

[...]

>
> > {
> > struct kvm_vm *vm;
> >
> > @@ -139,8 +139,7 @@ struct kvm_vm *_vm_create(enum vm_guest_mode mode, uint64_t phy_pages,
> > TEST_ASSERT(vm != NULL, "Insufficient Memory");
> >
> > vm->mode = mode;
> > - vm->type = type;
> > - vm_open(vm, perm, type);
> > + vm->type = 0;
> >
> > /* Setup mode specific traits. */
> > switch (vm->mode) {
> > @@ -190,6 +189,13 @@ struct kvm_vm *_vm_create(enum vm_guest_mode mode, uint64_t phy_pages,
> > TEST_ASSERT(false, "Unknown guest mode, mode: 0x%x", mode);
> > }
> >
> > +#ifdef __aarch64__
> > + if (vm->pa_bits != 40)
> > + vm->type = KVM_VM_TYPE_ARM_IPA_SIZE(guest_pa_bits);
> ^^
> should be vm->pa_bits

Thanks for spotting it! Fixed this and also the rest of indent
issues.

Regards,

--
Peter Xu

\
 
 \ /
  Last update: 2019-08-29 03:42    [W:0.309 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site