lkml.org 
[lkml]   [2019]   [Aug]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v2] ipv6: Not to probe neighbourless routes
    From
    From: <wang.yi59@zte.com.cn>
    Date: Wed, 28 Aug 2019 16:50:08 +0800 (CST)

    > We used an older version of the kernel, and found that configuring default
    > route led to a lot of NS messages, which affected the real business.
    >
    > Although commit f547fac624be adds rate-limiting, there are still some
    > unreasonable things.
    >
    > We have tested this change on CentOS 7.6 (3.10.0-957), whose rt6_probe()
    > implementation is similar to the latest code. When remaking patch based on
    > linux-5.3-rc5, a line of code was missed out with a mistack.

    Therefore, you are not testing this patch on current kernels, so you are
    sending a patch which is completely untested.

    This is not appropriate nor accceptable.

    \
     
     \ /
      Last update: 2019-08-28 21:55    [W:4.864 / U:0.212 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site