lkml.org 
[lkml]   [2019]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 07/98] bonding: Force slave speed check after link state recovery for 802.3ad
    Date
    [ Upstream commit 12185dfe44360f814ac4ead9d22ad2af7511b2e9 ]

    The following scenario was encountered during testing of logical
    partition mobility on pseries partitions with bonded ibmvnic
    adapters in LACP mode.

    1. Driver receives a signal that the device has been
    swapped, and it needs to reset to initialize the new
    device.

    2. Driver reports loss of carrier and begins initialization.

    3. Bonding driver receives NETDEV_CHANGE notifier and checks
    the slave's current speed and duplex settings. Because these
    are unknown at the time, the bond sets its link state to
    BOND_LINK_FAIL and handles the speed update, clearing
    AD_PORT_LACP_ENABLE.

    4. Driver finishes recovery and reports that the carrier is on.

    5. Bond receives a new notification and checks the speed again.
    The speeds are valid but miimon has not altered the link
    state yet. AD_PORT_LACP_ENABLE remains off.

    Because the slave's link state is still BOND_LINK_FAIL,
    no further port checks are made when it recovers. Though
    the slave devices are operational and have valid speed
    and duplex settings, the bond will not send LACPDU's. The
    simplest fix I can see is to force another speed check
    in bond_miimon_commit. This way the bond will update
    AD_PORT_LACP_ENABLE if needed when transitioning from
    BOND_LINK_FAIL to BOND_LINK_UP.

    CC: Jarod Wilson <jarod@redhat.com>
    CC: Jay Vosburgh <j.vosburgh@gmail.com>
    CC: Veaceslav Falico <vfalico@gmail.com>
    CC: Andy Gospodarek <andy@greyhouse.net>
    Signed-off-by: Thomas Falcon <tlfalcon@linux.ibm.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/bonding/bond_main.c | 9 +++++++++
    1 file changed, 9 insertions(+)

    diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
    index 8f14f85b8e95e..0d2392c4b625a 100644
    --- a/drivers/net/bonding/bond_main.c
    +++ b/drivers/net/bonding/bond_main.c
    @@ -2190,6 +2190,15 @@ static void bond_miimon_commit(struct bonding *bond)
    bond_for_each_slave(bond, slave, iter) {
    switch (slave->new_link) {
    case BOND_LINK_NOCHANGE:
    + /* For 802.3ad mode, check current slave speed and
    + * duplex again in case its port was disabled after
    + * invalid speed/duplex reporting but recovered before
    + * link monitoring could make a decision on the actual
    + * link status
    + */
    + if (BOND_MODE(bond) == BOND_MODE_8023AD &&
    + slave->link == BOND_LINK_UP)
    + bond_3ad_adapter_speed_duplex_changed(slave);
    continue;

    case BOND_LINK_UP:
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-08-27 10:14    [W:4.143 / U:0.160 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site