lkml.org 
[lkml]   [2019]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.2 079/162] drm/rockchip: Suspend DP late
    Date
    [ Upstream commit f7ccbed656f78212593ca965d9a8f34bf24e0aab ]

    In commit fe64ba5c6323 ("drm/rockchip: Resume DP early") we moved
    resume to be early but left suspend at its normal time. This seems
    like it could be OK, but casues problems if a suspend gets interrupted
    partway through. The OS only balances matching suspend/resume levels.
    ...so if suspend was called then resume will be called. If suspend
    late was called then resume early will be called. ...but if suspend
    was called resume early might not get called. This leads to an
    unbalance in the clock enables / disables.

    Lets take the simple fix and just move suspend to be late to match.
    This makes the PM core take proper care in keeping things balanced.

    Fixes: fe64ba5c6323 ("drm/rockchip: Resume DP early")
    Signed-off-by: Douglas Anderson <dianders@chromium.org>
    Signed-off-by: Sean Paul <seanpaul@chromium.org>
    Link: https://patchwork.freedesktop.org/patch/msgid/20190802184616.44822-1-dianders@chromium.org
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
    index 95e5c517a15f7..9aae3d8e99ef4 100644
    --- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
    +++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
    @@ -432,7 +432,7 @@ static int rockchip_dp_resume(struct device *dev)

    static const struct dev_pm_ops rockchip_dp_pm_ops = {
    #ifdef CONFIG_PM_SLEEP
    - .suspend = rockchip_dp_suspend,
    + .suspend_late = rockchip_dp_suspend,
    .resume_early = rockchip_dp_resume,
    #endif
    };
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-08-27 10:10    [W:4.042 / U:0.560 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site