Messages in this thread | | | Date | Tue, 27 Aug 2019 15:03:19 -0700 (PDT) | Subject | Re: [PATCH net-next v5] sched: Add dualpi2 qdisc | From | David Miller <> |
| |
From: "Tilmans, Olivier (Nokia - BE/Antwerp)" <olivier.tilmans@nokia-bell-labs.com> Date: Thu, 22 Aug 2019 08:10:48 +0000
> +static inline struct dualpi2_skb_cb *dualpi2_skb_cb(struct sk_buff *skb)
Please do not use the inline keyword in foo.c files, let the compiler decide.
> +static struct sk_buff *dualpi2_qdisc_dequeue(struct Qdisc *sch) > +{ > + struct dualpi2_sched_data *q = qdisc_priv(sch); > + struct sk_buff *skb; > + int qlen_c, credit_change;
Reverse christmas tree here, please.
> +static void dualpi2_timer(struct timer_list *timer) > +{ > + struct dualpi2_sched_data *q = from_timer(q, timer, pi2.timer); > + struct Qdisc *sch = q->sch; > + spinlock_t *root_lock; /* Lock to access the head of both queues. */
Likewise, and please remove this comment it makes the variable declarations look odd.
| |