Messages in this thread | | | Subject | Re: [PATCH v1] kunit: fix failure to build without printk | From | Stephen Boyd <> | Date | Tue, 27 Aug 2019 14:46:12 -0700 |
| |
Quoting Brendan Higgins (2019-08-27 10:49:32) > Previously KUnit assumed that printk would always be present, which is > not a valid assumption to make. Fix that by ifdefing out functions which > directly depend on printk core functions similar to what dev_printk > does. > > Reported-by: Randy Dunlap <rdunlap@infradead.org> > Link: https://lore.kernel.org/linux-kselftest/0352fae9-564f-4a97-715a-fabe016259df@kernel.org/T/#t > Cc: Stephen Rothwell <sfr@canb.auug.org.au> > Signed-off-by: Brendan Higgins <brendanhiggins@google.com> > ---
Does kunit itself have any meaning if printk doesn't work? Why not just depend on CONFIG_PRINTK for now?
| |