Messages in this thread | | | Date | Tue, 27 Aug 2019 21:48:06 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH v2 1/4] x86/vmware: Update platform detection code for VMCALL/VMMCALL hypercalls |
| |
On Tue, Aug 27, 2019 at 09:19:54PM +0200, Thomas Hellström (VMware) wrote: > We *do* have checkpatch.pl in the workflow. In this case I figured the > warnings actually didn't make sense. There are breaks present and > -Wimplicit-fallthrough doesn't complain...
Oh, we have enabled that by default already:
a035d552a93b ("Makefile: Globally enable fall-through warning")
I guess checkpatch wrongly complains here and I did trust its output blindly. That ain't happening again, sorry about that.
-- Regards/Gruss, Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
| |